-
Notifications
You must be signed in to change notification settings - Fork 22
[livemate] New Livemate Panel #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| const timeoutId = setTimeout(() => controller.abort(), timeoutMs); | ||
|
|
||
| try { | ||
| const response = await fetch('http://localhost:8081/livemate', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we've discussed, this probably won't work with OD case.
We should get more clarity on the approach, before committing to any changes on Frontend side.
| @@ -1 +0,0 @@ | |||
| file://config/owner/INFRA_OWNERS | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accidental change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, bad rebase caused a bunch of random changes I think.
| * This binding is installed on the React Native side and called when | ||
| * Inspector selects an element to propagate view data to DevTools. | ||
| */ | ||
| export const LIVEMATE_BINDING_NAME = '__livemate_devtools_binding'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see binding, I've just added reviewed the backend part in jsinspector-modern, and I suggested to use them.
Didn't see it being used on JavaScript side, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I don't see it being used here in Livemate panel code as well
| this.#queryInput.setAttribute('placeholder', i18nString(UIStrings.queryPlaceholder)); | ||
| this.#queryInput.setAttribute( | ||
| 'style', | ||
| 'flex: 1; padding: 12px 16px; border: 1px solid var(--sys-color-divider); border-radius: 4px; background: var(--sys-color-cdt-base-container); color: var(--sys-color-on-surface); font-size: 14px; min-height: 100px; resize: vertical; font-family: inherit;' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move these to css files?
Summary
This change adds a new experimental panel for AI integration with React Native.
Test plan
Needs a few other changes to test E2E. Panel can be toggled with the experimental flag
Enable Livemate Panel.Upstreaming plan
devtools-frontendrepo following the contribution guide for Meta employees OR contribution guide.